feat: Implement the GPU Info gathering within the Native SDK #1336

mujacica · 2025-08-11T10:30:27Z

Implement GPU Info Context for Native SDK
Support for Mac/Windows/Unix (Vulkan, Dynamically loaded)
Support for several Vendors
Added SENTRY_WITH_GPU_INFO option, ON by default on supported platforms
Include vulkan-headers as submodule

github-actions · 2025-08-11T10:30:47Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f7eef2b

bruno-garcia

Just skimmed things but seems great so far!

README.md

src/gpu/sentry_gpu_common.c

src/gpu/sentry_gpu_unix.c

bruno-garcia · 2025-10-02T16:27:17Z

@sentry review

src/gpu/sentry_gpu_vulkan.c

src/gpu/sentry_gpu_common.c

src/gpu/sentry_gpu_vulkan.c

src/gpu/sentry_gpu_common.c

src/gpu/sentry_gpu_vulkan.c

tests/unit/test_gpu.c

src/gpu/sentry_gpu_common.c

src/gpu/sentry_gpu_vulkan.c

README.md

supervacuus

Somehow my review message got lost... this looks great. Only minor topics that can be "fixed" or clarified.

Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>

src/gpu/sentry_gpu_unix.c

src/gpu/sentry_gpu_common.c

tests/test_integration_gpu.py

bruno-garcia reviewed Aug 11, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

src/gpu/sentry_gpu_common.c Outdated Show resolved Hide resolved

src/gpu/sentry_gpu_unix.c Outdated Show resolved Hide resolved

mujacica force-pushed the native-gpu-info branch from 883b465 to d743b13 Compare October 2, 2025 12:43

mujacica marked this pull request as ready for review October 2, 2025 13:22

This comment was marked as outdated.

Sign in to view

mujacica requested review from JoshuaMoelans and supervacuus October 2, 2025 15:05

mujacica added 23 commits October 2, 2025 17:39

feat: Implement the GPU Info gathering within the Native SDK

c65001f

Fix file format

fab50a7

Add changelog entry

e1854e3

Extend README with new SENTRY_WITH_GPU_INFO option

dc72b0e

Skip apple silicon tests on non darwin platforms

093d100

Enable GPU Info per default to test cmake on github runners

c3fc125

Resolve compiler issues on Linux

de8516a

Fix Windows builds

1bf85b3

Fix failing tests

cfb142b

Fix IOS builds

63285cd

Fix remaining failing tests

0be6800

Fix format

6d5d211

Keep GPU Info disabled by default

75436f6

Fix CMake for all platforms

b337dc9

Fix comments, and findings from testing

324aa86

Further testing fixes

15cbc84

Fix failing test

90e801e

Use Sentry wstr function instead of custom implementation

a56f85d

Simplify Unix implementation and CMakeLists

4c9023f

Add nvml support, add multi-gpu support

a5bc079

Fix linux complier warnings

18edccc

Fix file formats

86ba123

Fix build issues after refactoring

abd63a8

mujacica force-pushed the native-gpu-info branch from 960eb4f to 0c22332 Compare October 2, 2025 15:42

seer-by-sentry bot reviewed Oct 2, 2025

View reviewed changes

src/gpu/sentry_gpu_vulkan.c Show resolved Hide resolved

src/gpu/sentry_gpu_vulkan.c Show resolved Hide resolved

src/gpu/sentry_gpu_vulkan.c Show resolved Hide resolved

src/gpu/sentry_gpu_vulkan.c Show resolved Hide resolved

src/gpu/sentry_gpu_common.c Show resolved Hide resolved

supervacuus reviewed Oct 7, 2025

View reviewed changes

supervacuus requested changes Oct 7, 2025

View reviewed changes

mujacica and others added 4 commits October 9, 2025 10:40

Update src/gpu/sentry_gpu_vulkan.c

924aef3

Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>

Update src/gpu/sentry_gpu_vulkan.c

641744d

Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>

Update tests/unit/test_gpu.c

921f817

Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>

Update README.md

150e542

Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>

This comment was marked as outdated.

Sign in to view

Fix PR Comments

899d2fb

This comment was marked as outdated.

Sign in to view

Update tests/unit/test_gpu.c

6b37c65

Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>

This comment was marked as outdated.

Sign in to view

Further fixes

284dfd0

This comment was marked as outdated.

Sign in to view

Fix memory units

d610338

This comment was marked as outdated.

Sign in to view

Fix docs

022ec51

This comment was marked as outdated.

Sign in to view

Fix more comments

6b4e712

This comment was marked as outdated.

Sign in to view

Fix Mac compatibility

7de05b4

This comment was marked as outdated.

Sign in to view

mujacica requested a review from supervacuus October 9, 2025 11:06

JoshuaMoelans reviewed Oct 9, 2025

View reviewed changes

src/gpu/sentry_gpu_unix.c Outdated Show resolved Hide resolved

src/gpu/sentry_gpu_common.c Show resolved Hide resolved

src/gpu/sentry_gpu_common.c Show resolved Hide resolved

tests/test_integration_gpu.py Show resolved Hide resolved

supervacuus approved these changes Oct 9, 2025

View reviewed changes

Fix Vendor ID's

bb12c54

This comment was marked as outdated.

Sign in to view

Fix memory size to MB

f7eef2b

Uh oh!

feat: Implement the GPU Info gathering within the Native SDK #1336

Are you sure you want to change the base?

feat: Implement the GPU Info gathering within the Native SDK #1336

Uh oh!

Conversation

mujacica commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bruno-garcia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

bruno-garcia commented Oct 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

supervacuus left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mujacica commented Aug 11, 2025 •

edited

Loading

github-actions bot commented Aug 11, 2025 •

edited

Loading